add temporary solution for linking to classes from different project #248
Conversation
|
Thanks @MartinMalinda will pull it down and try it out. Can you fix up the eslint errors for CI? |
MartinMalinda
force-pushed
the
links-between-projects
branch
from
27bcd78 to
e3b9862
Compare
|
@toddjordan Fixed! |
| @@ -8,7 +8,7 @@ | |||
| {{#if model.extends}} | |||
| <div class="attribute"> | |||
| <span class="attribute-label">Extends:</span> | |||
| <span class="attribute-value">{{#link-to 'project-version.classes.class' model.projectVersion.version model.extends}}{{model.extends}}{{/link-to}}</span> | |||
| <span class="attribute-value">{{#link-to 'project-version.classes.class' model.extendedClassProjectName model.extendedClassVersion model.extends}}{{model.extends}}{{/link-to}}</span> | |||
There was a problem hiding this comment.
the name is available from the route. we should be able to pass it to the template instead of guessing in the model object. you can get it from transition.params['project-version'].project in the model hook.
There was a problem hiding this comment.
The issue is, transitioning from Ember Data 2.14 to Ember 2.14 can break the app if Ember 2.14 is not released yet.
There was a problem hiding this comment.
wasn't talking about version, but referring to model.extendedClassProjectName
There was a problem hiding this comment.
Ah, well then it would not solve anything, we'd be linking to from ember-data to ember-data same as before, having broken link. We need to be able to link from ember-data to ember back and forth.
There was a problem hiding this comment.
ok, I get what's happening now. this is the link to a class that the current one is exteded from cross project. disregard 👍
A temporary and dirty solution for #243.
Ideally, the properties that are currently computed properties on the class model would be provided by
ember-json-api-docs.Another option would to transform
usesandextendsinto relationships. But that could result in extra network requests... or JSON-API could take care of that viainclude?