Bump accesskit to 0.18 and make it a workspace dependency #5783
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/5783-bump-accesskit |
valadaptive
force-pushed
the
bump-accesskit
branch
from
ee4f632 to
cee1ad9
Compare
Cargo.toml
Outdated
| @@ -83,7 +85,7 @@ glutin = { version = "0.32.0", default-features = false } | |||
| glutin-winit = { version = "0.5.0", default-features = false } | |||
| home = "0.5.9" | |||
| image = { version = "0.25", default-features = false } | |||
| kittest = { version = "0.1" } | |||
| kittest = { git = "https://github.com/valadaptive/kittest", rev = "9b2b8cd" } | |||
There was a problem hiding this comment.
For now we can use kittest from master. I'll release a new version with the next egui release.
There was a problem hiding this comment.
Updated kittest to the latest git version. cargo-deny is complaining about a wildcard dependency; not sure why. Do I need to specify an explicit git revision?
There was a problem hiding this comment.
Hmm, no idea 🤔 Maybe it works when added as a patch instead?
There was a problem hiding this comment.
Alright, it seems that cargo-deny doesn't allow git dependencies unless the allow-wildcard-paths option is enabled, and doesn't allow git dependencies in public crates regardless of what that option is set to. Since egui_kittest is a public crate, cargo-deny will fail until a new version of kittest is published that we can switch to.
valadaptive
force-pushed
the
bump-accesskit
branch
from
54e4815 to
75a6b52
Compare
|
Specifying the kittest version seems to do the trick |
This can't be merged until kittest's accesskit is bumped
and a new version of rfd is released.