feat: introduce reset_options/2 facility
#202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meant to be used in situations when `set_options/2` is too dumb: e.g. changing TLS version such that in turn makes existing TLS server options incompatible.
ieQu1
reviewed
Mar 27, 2025
src/esockd.erl
Outdated
| OptionsMerged = merge_opts(OptionsWas, Options), | ||
| with_listener_ref(ListenerRef, ?FUNCTION_NAME, [OptionsMerged]). | ||
|
|
||
| %% @doc Replace set of applicable options |
There was a problem hiding this comment.
This comment is not very descriptive. What does "reset" mean? Merge given options with the defaults?
There was a problem hiding this comment.
See refined comments.
ieQu1
reviewed
Mar 27, 2025
ieQu1
approved these changes
Mar 27, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to be used in situations when
set_options/2is too dumb: e.g. changing TLS version that in turn renders existing TLS server options incompatible.See individual commits for details.