Inherit LD_PRELOAD env vars to support sysconfcpus #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
==========================================
+ Coverage 97.44% 97.52% +0.07%
==========================================
Files 11 11
Lines 313 323 +10
==========================================
+ Hits 305 315 +10
Misses 8 8
Continue to review full report at Codecov.
|
ento
force-pushed
the
sysconfcpus-support
branch
from
d2b5c48 to
b19c36c
Compare
ento
force-pushed
the
sysconfcpus-support
branch
from
83ba7a6 to
a0c3cb6
Compare
ento
force-pushed
the
sysconfcpus-support
branch
from
b0e6110 to
0937f0e
Compare
|
travis agrees, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysconfcpus also uses
LD_PRELOADto hijacksysconfand override the number of cpus that elm-make thinks it has, in order not to hog the system.elm-doc hijacks
open, a different function, so there's no conflict: we simply need to pass on the necessary environment variables to theelm-makeprocess we launch to let sysconfcpus do its thing.Also added retrying logic (with the help of a package) to elm-package install that happens during the build.