trace API: commit state changes from InitializeBlockExecution #12559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
requested review from
sudeepdino008,
somnathb1,
AskAlexSharov and
taratorio
taratorio
approved these changes
Oct 31, 2024
This was referenced Oct 31, 2024
yperbasis
added a commit
that referenced
this pull request
Oct 31, 2024
Prior to this PR in `callManyTransactions` (invoked by `trace_block`) changes made by `InitializeBlockExecution` were discarded, leading to issues like #12432. That was immaterial before since no much was happening at the beginning of a block. But that changed in Dencun with [EIP-4788](https://eips.ethereum.org/EIPS/eip-4788) – see `(s *Merge) Initialize`.
yperbasis
added a commit
that referenced
this pull request
Oct 31, 2024
Duplicate #12559 into `release/2.61`
This was referenced Oct 31, 2024
somnathb1
pushed a commit
that referenced
this pull request
Nov 4, 2024
Duplicate #12559 into `release/2.61`
yperbasis
added a commit
that referenced
this pull request
Dec 16, 2024
yperbasis
added a commit
that referenced
this pull request
Dec 16, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR in
callManyTransactions(invoked bytrace_block) changes made byInitializeBlockExecutionwere discarded, leading to issues like #12432. That was immaterial before since no much was happening at the beginning of a block. But that changed in Dencun with EIP-4788 – see(s *Merge) Initialize.