txnprovider/txpool: move more txpool types out of erigon-lib #12725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratorio
commented
Nov 14, 2024
| @@ -150,106 +144,3 @@ func (mf MergedFiles) Close() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func DecodeAccountBytes(enc []byte) (nonce uint64, balance *uint256.Int, hash []byte) { | |||
taratorio
commented
Nov 14, 2024
| return | ||
| } | ||
|
|
||
| func EncodeAccountBytes(nonce uint64, balance *uint256.Int, hash []byte, incarnation uint64) []byte { |
taratorio
commented
Nov 14, 2024
| import ( | ||
| "github.com/holiman/uint256" | ||
| ) | ||
|
|
There was a problem hiding this comment.
moved back inside relevant tests that are using it in txnprovider/txpool
taratorio
commented
Nov 14, 2024
| // nolint | ||
| func (tx *TxSlot) PrintDebug(prefix string) { | ||
| fmt.Printf("%s: senderID=%d,nonce=%d,tip=%d,v=%d\n", prefix, tx.SenderID, tx.Nonce, tx.Tip, tx.Value.Uint64()) | ||
| //fmt.Printf("%s: senderID=%d,nonce=%d,tip=%d,hash=%x\n", prefix, tx.senderID, tx.nonce, tx.tip, tx.IdHash) | ||
| } | ||
|
|
||
| // AccessList is an EIP-2930 access list. | ||
| type AccessList []AccessTuple |
There was a problem hiding this comment.
moved to core/types alongside AccessListTx
AskAlexSharov
approved these changes
Nov 15, 2024
taratorio
commented
Nov 15, 2024
|
|
||
| // This test actually applies to testing the behaviour as seen from the | ||
| // onNewTx behaviour in filters.go | ||
| func TestShortUnwrapLib(t *testing.T) { |
There was a problem hiding this comment.
this test and TestShortUnwrap are 1:1 the same now
taratorio
commented
Nov 15, 2024
| @@ -738,89 +734,21 @@ func TestBlobTxEncodeDecode(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func makeBlobTxRlp() []byte { | |||
There was a problem hiding this comment.
moved to core/types/typestest pkg
somnathb1
pushed a commit
that referenced
this pull request
Jan 24, 2025
move last bits of txpool related types out of erigon-lib in subsequent PRs will further split and organise some of these into better packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #13377
move last bits of txpool related types out of erigon-lib
in subsequent PRs will further split and organise some of these into better packages