Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put reasonable feeCap value in tests #13612

Merged
merged 2 commits into from
Jan 31, 2025
Merged

put reasonable feeCap value in tests #13612

merged 2 commits into from
Jan 31, 2025

Conversation

dvovk
Copy link
Member

@dvovk dvovk commented Jan 29, 2025 •
edited
Loading

Set default FeeCap value (1eth) for tests.
Looks like there is mistake in #10636
checkTxFee function expects FeeCap in Ether not in Wei.

erigon/turbo/jsonrpc/send_transaction.go

Line 80 in 34714c0

feeEth := new(big.Float).Quo(new(big.Float).SetInt(new(big.Int).Mul(gasPrice, new(big.Int).SetUint64(gas))), new(big.Float).SetInt(big.NewInt(params.Ether)))

@dvovk dvovk requested a review from shohamc1 January 29, 2025 19:16
@shohamc1 shohamc1 mentioned this pull request Jan 31, 2025
Merged
@dvovk dvovk merged commit 07fec89 into main Jan 31, 2025
13 checks passed
@dvovk dvovk deleted the fix_api_create branch January 31, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shohamc1 shohamc1 shohamc1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvovk @shohamc1