snapshots: improve verbose dump in count subcommands #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
approved these changes
Oct 16, 2024
Comment on lines
265
to
+281
| auto duration_as(const std::chrono::duration<R, P>& elapsed) { | ||
| return std::chrono::duration_cast<D>(elapsed).count(); | ||
| } | ||
|
|
||
| //! Convert the given duration into milliseconds | ||
| //! \param elapsed the duration to convert | ||
| template <typename R, typename P> | ||
| auto as_milliseconds(const std::chrono::duration<R, P>& elapsed) { | ||
| return duration_as<std::chrono::milliseconds>(elapsed); | ||
| } | ||
|
|
||
| //! Convert the given duration into seconds | ||
| //! \param elapsed the duration to convert | ||
| template <typename R, typename P> | ||
| auto as_seconds(const std::chrono::duration<R, P>& elapsed) { | ||
| return duration_as<std::chrono::seconds>(elapsed); | ||
| } |
There was a problem hiding this comment.
After watching a talk on chrono I believe that this is not a proper usage of duration_cast. A better approach is to create a string format_duration(duration). I suggest to format it to seconds with ms fractional part e.g.: 12.455 sec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.