Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcdaemon: fix mismatch in erigon_getHeaderBy[Hash|Number] #2454

Merged
merged 12 commits into from
Oct 29, 2024
+105 −71
Merged

rpcdaemon: fix mismatch in erigon_getHeaderBy[Hash|Number] #2454

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
189fd5e
add requestsHash field
lupin012 Oct 25, 2024
05efc35
update execption list
lupin012 Oct 25, 2024
a7ef233
modify definition of get_block_number_from_hash into optional<BlockNum>
lupin012 Oct 25, 2024
a60c849
add optional to get_block_hash_from_block_number
lupin012 Oct 25, 2024
87676ec
add getBalance on exception list
lupin012 Oct 25, 2024
92cb2d4
emable eth_getbalance/test_05
lupin012 Oct 26, 2024
bf9b02d
fix test getBalance
lupin012 Oct 26, 2024
afacc07
remove comment
lupin012 Oct 26, 2024
de801ac
enable again websocket
lupin012 Oct 26, 2024
05c853e
update rpc.-int test
lupin012 Oct 28, 2024
f7c4c13
Update remote_chain_storage.cpp
canepat Oct 29, 2024
3c13702
Update remote_chain_storage.cpp
canepat Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add requestsHash field
@lupin012
lupin012 committed Oct 26, 2024
commit 189fd5eb53a19035e22d47925d2b4d9ce88b5ff0
1 change: 1 addition & 0 deletions silkworm/rpc/json/types.cpp
View file
Original file line number Diff line number Diff line change
@@ -233,6 +233,7 @@ void to_json(nlohmann::json& json, const BlockHeader& header) {
json["Verkle"] = false;
json["VerkleKeyVals"] = nullptr;
json["VerkleProof"] = nullptr;
json["requestsHash"] = nullptr;
}
if (header.blob_gas_used) {
json["blobGasUsed"] = rpc::to_quantity(*header.blob_gas_used);
3 changes: 3 additions & 0 deletions silkworm/rpc/json/types_test.cpp
View file
Original file line number Diff line number Diff line change
@@ -195,6 +195,7 @@ TEST_CASE("serialize empty block header", "[rpc][to_json]") {
"Verkle":false,
"VerkleKeyVals":null,
"VerkleProof":null,
"requestsHash":null,
"blobGasUsed":null,
"excessBlobGas": null,
"parentBeaconBlockRoot": null
@@ -250,6 +251,7 @@ TEST_CASE("serialize block header", "[rpc][to_json]") {
"Verkle":false,
"VerkleKeyVals":null,
"VerkleProof":null,
"requestsHash":null,
"blobGasUsed":null,
"excessBlobGas": null,
"parentBeaconBlockRoot": null
@@ -308,6 +310,7 @@ TEST_CASE("serialize block header with baseFeePerGas", "[rpc][to_json]") {
"Verkle":false,
"VerkleKeyVals":null,
"VerkleProof":null,
"requestsHash":null,
"blobGasUsed":null,
"excessBlobGas": null,
"parentBeaconBlockRoot": null