Added test for gradient flow and verifying that the deviation from th… #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e original fdtd is not significant
gomezzz
requested changes
Apr 28, 2022
nidn/tests/fdtd_test.py
Outdated
| grid.run(cfg.FDTD_niter) | ||
| t_signal_material, r_ = _get_detector_values(t_detector_material, _) | ||
| # Original fdtd | ||
| import fdtd |
There was a problem hiding this comment.
wouldn't it be easier to just hard-coded save the output values from the original FDTD? If the FDTD module changes in the future otherwise we may get an error here 🤔
There was a problem hiding this comment.
(still do keep the code to reproduce the code to create the ground truth in a comment in here ideally so we can easily update values if ever necessary)
There was a problem hiding this comment.
Where should I put the code for the generation? The code is the same as in the generate ground-truth data notebook
gomezzz
approved these changes
Apr 29, 2022
nidn/tests/fdtd_test.py
Outdated
| # Add only the z component of the E field from the center point of the detector, as there is only z polarized waves | ||
| raw_signal.append(t_detector_material.detector_values()["E"][i][1][2]) | ||
| t.append(i) | ||
| original_fdtd = [ |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e original fdtd is not significant
Description
As title
Resolved Issues
How Has This Been Tested?
pytest