Fix Progmem read over optimization #3164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler is overoptimizing a 32bit aligned read to the requested size (8 or 16 bit) but due to the flash requirement that reads must always be 32bits in size this will cause an exception when the code is run. This change hints to the compiler that it can't optimize the read size.
Codecov Report
@@ Coverage Diff @@
## master #3164 +/- ##
======================================
Coverage 27.6% 27.6%
======================================
Files 20 20
Lines 3655 3655
Branches 678 678
======================================
Hits 1009 1009
Misses 2468 2468
Partials 178 178Continue to review full report at Codecov.
|
|
Decided to go for inline assembly approach, but thanks for the PR and looking into this @Makuna! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler is overoptimizing a 32bit aligned read to the requested
size (8 or 16 bit) but due to the flash requirement that reads must
always be 32bits in size this will cause an exception when the code is
run.
This change hints to the compiler that it can't optimize the read size.