Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-7594 (PeerDAS) related changes #630

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

0x00101010
Copy link

@0x00101010 0x00101010 commented Feb 19, 2025

Summary

Introduces updates to rpc and engine API definitions for EIP-7594, changes defined in ethereum/EIPs#9378

  • Adjusts schemas for blob transactions (blob.yaml) and references to ensure consistency across all updated files.
  • Added osaka.md to describe api changes

Notes for reviewers

This PR introduces backward incompatible changes to engine_getPayloadV4, that returns new BlobsBundleV2 with cell proofs instead of blob proofs

0x00101010 and others added 3 commits February 20, 2025 15:27
Co-authored-by: fradamt <104826920+fradamt@users.noreply.github.com>
Co-authored-by: fradamt <104826920+fradamt@users.noreply.github.com>
Copy link

@ImTei ImTei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve added a few suggestions to slightly improve readability and clarity—mostly minor points for precision. None of them are strictly necessary, so please feel free to accept or ignore them based on your preference!

0x00101010 and others added 2 commits March 4, 2025 11:12
Co-authored-by: Tei Im <40449056+ImTei@users.noreply.github.com>
Co-authored-by: Tei Im <40449056+ImTei@users.noreply.github.com>
Copy link
Contributor

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a question / request for clarification on the eth_sendRawTransaction semantics


## Methods

### engine_getPayloadV5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much effort is it to make these endpoints return in SSZ encoding? I'd imagine JSON serialisation and deserialisation would take much longer with much higher blob count.

Given that engine has SSZ encoding capability (blob is already SSZ encoded), is it possible to support SSZ encoding the entire endpoint responses?

Copy link
Contributor

@jimmygchen jimmygchen Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh never mind - i think SSZ encoding the blobs already provide most of the savings on blobs.

actually, no, this is still hex encoded for JSON wrapped in a string, so it's still slow and expensive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peter mentioned it before here:
https://x.com/peter_szilagyi/status/1841424117733478650

We should seriously consider doing this to support high blob count.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should seriously consider doing this to support high blob count.

the way the current engine-api is designed makes it almost impossible to add ssz as a wire format, yesterday the geth team mentioned they are working on a rest api following the beacon-api design, I think this is the right step forward, not only for blobs but also if we wanna bump up the gas limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.