core: fix when db empty on startup overrides for TTD and gray glacier do not work #25146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolara
commented
Jun 22, 2022
| @@ -250,6 +250,7 @@ func SetupGenesisBlockWithOverride(db ethdb.Database, genesis *Genesis, override | |||
| if err != nil { | |||
| return genesis.Config, common.Hash{}, err | |||
| } | |||
| performConfigOverride(genesis.Config, overrideGrayGlacier, overrideTerminalTotalDifficulty) | |||
There was a problem hiding this comment.
perhaps we should clone genesis.Config before overriding it?
There was a problem hiding this comment.
0x62044d2cab405388891ee6d53747817f34c0f00341cde548c0ce9834e9718f27
leolara
commented
Jun 22, 2022
| @@ -322,6 +313,15 @@ func SetupGenesisBlockWithOverride(db ethdb.Database, genesis *Genesis, override | |||
| return newcfg, stored, nil | |||
| } | |||
|
|
|||
| func performConfigOverride(cfg *params.ChainConfig, overrideGrayGlacier *big.Int, overrideTerminalTotalDifficulty *big.Int) { | |||
There was a problem hiding this comment.
perhaps there is a better place for this function? should I make it a unexported method of Genesis? Does it need documentation, other private methods don't have?
There was a problem hiding this comment.
0x62044d2cab405388891ee6d53747817f34c0f00341cde548c0ce9834e9718f27
|
Thanks, but there's already a PR open to tackle this #25136 |
|
@karalabe ok, no worries. Is there a specific discord channel to discuss geth contributions, so I can talk about what I am doing before doing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25133
My first go-ethereum contribution, but I done some on prysm: https://github.com/prysmaticlabs/prysm/pulls?q=+is%3Apr+author%3Aleolara+
Please, let me know how to improve this PR.