Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/kzg4844: add ComputeCells functionality #31378

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

crypto/kzg4844: add ComputeCells functionality #31378

wants to merge 5 commits into from
+4,185 −21

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Mar 13, 2025 •
edited
Loading

For PeerDAS, we need to compute cell proofs. Both ckzg and gokzg support computing these cell proofs.
This PR does the following:

  • Update the go-kzg library from "github.com/crate-crypto/go-kzg-4844" to "github.com/crate-crypto/go-eth-kzg" which will be the new upstream for go-kzg moving forward
  • Update ckzg from v1.0.0 to v2.0.1 and switch to /v2
  • Updates the trusted setup to contain the g1 points both in lagrange and monomial form
  • Expose ComputeCells to compute the cell proofs

@MariusVanDerWijden
Copy link
Member Author

Problem rn is that gokzg startup is much slower now: crate-crypto/go-eth-kzg#110

@rjl493456442 rjl493456442 self-assigned this Mar 17, 2025
@rjl493456442
Copy link
Member

Please run go mod tidy to get rid of the old dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@jwasinger jwasinger Awaiting requested review from jwasinger jwasinger is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@fjl fjl Awaiting requested review from fjl fjl is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@rjl493456442 rjl493456442

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MariusVanDerWijden @rjl493456442