Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: create ItemPreviewInterface component #2672

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

refactor: create ItemPreviewInterface component #2672

wants to merge 35 commits into from

Conversation

rwd
Copy link
Contributor

@rwd rwd commented Mar 21, 2025 •
edited
Loading

  • incorporating heading, view toggles, multi-select, item preview card group, pagination, and methods from item preview card group view mixin
  • resulting in availability of item multi-select on: main search, entity pages, liked items
  • stop treating searches with 0 results as errors, which spam the APM logging
    • instead just display them like an illustrated error, via the ItemPreviewInterface's no-items slot

@rwd
refactor: create ItemPreviewInterface component
75ba1b9 
incorporating heading, view toggles, multi-select, item preview card
group, pagination, and methods from item preview card group view mixin
@rwd rwd marked this pull request as draft March 21, 2025 15:26
@github-actions GitHub Actions
Copy link

JIRA ticket: EC-7118

@rwd rwd marked this pull request as ready for review March 26, 2025 09:07
@github-actions GitHub Actions
Copy link

Preview deployment: https://pr-2672.portal-js.dev.eanadev.org/

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
98.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoniePeters LeoniePeters LeoniePeters requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwd @LeoniePeters