Heating: add generic heatpump charger #19008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premultiply
reviewed
Feb 20, 2025
premultiply
reviewed
Feb 20, 2025
This was referenced Feb 22, 2025
Closed
|
Will the Fronius Solar API mit Ohmpilot (nicht Wattpilot) be also one of the Power Controller use cases? Just asking, I do not have one ... |
|
Maybe, but right now there is no Ohmpilot charger. |
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19002, fix #18812
This PR refactors the SG Ready charger into an SG Ready mode controller (Enable(d)/ Status) and a Power controller (MaxCurrent). For power-controlled heating devices it also adds a
heatpumpcharger using a Power mode controller (again Enable(d)/ Status). Thus, controlling power (rather than current) and using that power or the notion of an SG Ready mode for Enable(d)/ Status behavior becomes composable modules. All standard charger readings like power, energy, (limit)soc/temp become default decorators.TODO