Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toyota): set expiry on refreshed token #19750

Conversation

thomasbecker
Copy link
Contributor

Should fix the problem that sometimes no refresh happens. Weird thing is that from my point of view refresh should have worked exactly once if that is the problem. However it takes several days for me to happen.

A build with this change is running on my box now and I will keep an eye on it.

@thomasbecker thomasbecker force-pushed the fix/set-expiry-on-refreshed-token branch from 04f6bc4 to c3cb8a6 Compare March 13, 2025 12:08
@andig
Copy link
Member

andig commented Mar 13, 2025

That’s indeed required. Can you use https://github.com/evcc-io/evcc/blob/master/util/token.go#L9?

@andig andig added the vehicles Specific vehicle support label Mar 13, 2025
@andig andig marked this pull request as draft March 13, 2025 13:09
@andig
Copy link
Member

andig commented Mar 14, 2025

@thomasbecker could you please give #19766 a try?

@andig andig closed this Mar 14, 2025
@thomasbecker
Copy link
Contributor Author

Did you want to notify me or the other guys from the bug? It’s already running on my box, but usually it takes a few days to show the problem. I’ll keep you posted if it still fails.

@thomasbecker thomasbecker mentioned this pull request Mar 14, 2025
2 tasks
@andig
Copy link
Member

andig commented Mar 14, 2025

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vehicles Specific vehicle support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants