This repository was archived by the owner on Jan 5, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97deeb4
to
b82b549
Compare
Closes #203 |
Rebased. |
I just tried rerunning the
And here's what the trace is showing me:
So maybe this didn't fix the issue? CC @hugo-dc
|
Double check you have everything set up properly. The test is passing for me. |
My bad. I was running with an older version of the code. This test is passing for me now, with this change. Cool. |
lrettig
approved these changes
Apr 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM
a5ba015
to
9acd181
Compare
Merging this as-is to get CI passing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203.
WIP I think we need to remove a lot of these
bswap*
statements as they are needlessly changing the endianness of certain values (AFAIK at some point they were used and then we made some changes to hera that flipped endianness expectations).