Add id to table rows by using table id and row id #23
Conversation
inline-gdocs-viewer.php
Outdated
| @@ -592,7 +592,8 @@ private function dataToHtml ($r, $options, $caption = '') { | |||
| $id = ( 0 === $this->invocations ) | |||
| ? 'igsv-' . $this->getDocId( $options['key'] ) | |||
| : "igsv-{$this->invocations}-" . $this->getDocId( $options['key'] ); | |||
| $html = '<table id="' . esc_attr( $id ) . '"'; | |||
| $id = esc_attr( $id ); | |||
| $html = '<table id="$id"'; | |||
There was a problem hiding this comment.
Unless I am misreading this, this hunk looks equivalent to the original. Why the change? If the functional execution of this hunk is the same as the original, please leave the original in place and remove this hunk from the commit. Thanks.
|
I've reverted that section, please take another look |
|
@ThaiWood Thanks for the update. Lastly, please clean this branch. Something like this should do it, I think: git checkout -b pr-23 fabacab/master # Make a new branch based on fabacab's "master" branch
git merge --squash add-row-id # Prepare a squashed commit of all the commits in the local `add-row-id` branch.
git commit -m "Add id to table rows by using table id and row id" # Commit that change set.
git push origin +pr-23:add-row-id # Forcibly overwrite the remote's ("origin") "add-row-id" branch with the contents of the new "pr-23" branch. |
|
squashed and overwritten as requested |
|
Fixed a typo in 616 where the quotes didn't match, and resquashed |
|
This was merged but the |
This allows linking directly to table rows, please let me know if further changes are wanted.