Allow importSource to be configured in preset-react #10580
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebuilds
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Can't say if this aligns with CRA goals as I'm not a maintainer here (I would very much appreciate this being configurable somehow though). I've just noticed your PR through some other ones and I think this one is in a slightly better shape right now. Just a heads up from my side but keep in mind that I'm just a bystander here :p |
|
will merge into #10583 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't verified if this works yet, just checking if it'd be cool if this were configurable