Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(LaunchScreen): 定义 Colors 对象的类型 #49966

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(LaunchScreen): 定义 Colors 对象的类型 #49966

wants to merge 1 commit into from
+9 −1

Conversation

qnnp-me
Copy link
Contributor

@qnnp-me qnnp-me commented Mar 12, 2025 •
edited
Loading

Changelog:

[GENERAL] [ADDED] - Added type definitions for Colors object in LaunchScreen module to enhance code readability and type safety.

@qnnp-me
refactor(LaunchScreen): 定义 Colors 对象的类型
4324394 
为 LaunchScreen 模块中的 Colors 对象定义了具体的类型，包括以下颜色属性：
- primary
- white
- lighter
- light
- dark
- darker
- black
这将有助于提高代码的可读性和类型安全性。
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2025
@react-native-bot
Copy link
Collaborator

react-native-bot commented Mar 12, 2025 •
edited
Loading

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 4324394

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Mar 12, 2025
@realsoelynn
Copy link
Contributor

realsoelynn commented Mar 12, 2025 •
edited
Loading

Thank you so much for improving the repo.

Please follow changelog formats guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qnnp-me @react-native-bot @realsoelynn @facebook-github-bot