Add asDynamic to EventPayload
#49988
Open
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71046682 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 12, 2025
Summary: NativeAnimated currently depends on folly::dynamic event payloads for event-driven animations. While some events (e.g., ScrollEvent.h) have an `asDynamic` implementation, not all events do. Having the ability to convert an EventPayload to a folly::dynamic defined on the EventPayload implementations precludes generalized event handling in NativeAnimated. This change moves the `asDynamic` method from `ScrollEvent` to the base `EventPayload` interface, defaulting the implemention to returning a null value. ## Changelog [Internal] Differential Revision: D71046682
rozele
force-pushed
the
export-D71046682
branch
from
fc3fa83 to
5166d0a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71046682 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 12, 2025
Summary: Pull Request resolved: facebook#49988 NativeAnimated currently depends on folly::dynamic event payloads for event-driven animations. While some events (e.g., ScrollEvent.h) have an `asDynamic` implementation, not all events do. Having the ability to convert an EventPayload to a folly::dynamic defined on the EventPayload implementations precludes generalized event handling in NativeAnimated. This change moves the `asDynamic` method from `ScrollEvent` to the base `EventPayload` interface, defaulting the implemention to returning a null value. ## Changelog [Internal] Differential Revision: D71046682
rozele
force-pushed
the
export-D71046682
branch
from
5166d0a to
c98edd2
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 12, 2025
Summary: NativeAnimated currently depends on folly::dynamic event payloads for event-driven animations. While some events (e.g., ScrollEvent.h) have an `asDynamic` implementation, not all events do. Having the ability to convert an EventPayload to a folly::dynamic defined on the EventPayload implementations precludes generalized event handling in NativeAnimated. This change moves the `asDynamic` method from `ScrollEvent` to the base `EventPayload` interface, defaulting the implemention to returning a null value. ## Changelog [Internal] Differential Revision: D71046682
rozele
force-pushed
the
export-D71046682
branch
from
c98edd2 to
f6ad12a
Compare
Summary: Pull Request resolved: facebook#49988 NativeAnimated currently depends on folly::dynamic event payloads for event-driven animations. While some events (e.g., ScrollEvent.h) have an `asDynamic` implementation, not all events do. Having the ability to convert an EventPayload to a folly::dynamic defined on the EventPayload implementations precludes generalized event handling in NativeAnimated. This change moves the `asDynamic` method from `ScrollEvent` to the base `EventPayload` interface, defaulting the implemention to returning a null value. ## Changelog [Internal] Differential Revision: D71046682
|
This pull request was exported from Phabricator. Differential Revision: D71046682 |
rozele
force-pushed
the
export-D71046682
branch
from
f6ad12a to
22bb968
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Mar 12, 2025
Summary: NativeAnimated currently depends on folly::dynamic event payloads for event-driven animations. While some events (e.g., ScrollEvent.h) have an `asDynamic` implementation, not all events do. Having the ability to convert an EventPayload to a folly::dynamic defined on the EventPayload implementations precludes generalized event handling in NativeAnimated. This change moves the `asDynamic` method from `ScrollEvent` to the base `EventPayload` interface, defaulting the implemention to returning a null value. ## Changelog [Internal] Reviewed By: zeyap Differential Revision: D71046682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
NativeAnimated currently depends on folly::dynamic event payloads for event-driven animations. While some events (e.g., ScrollEvent.h) have an
asDynamicimplementation, not all events do. Having the ability to convert an EventPayload to a folly::dynamic defined on the EventPayload implementations precludes generalized event handling in NativeAnimated.This change moves the
asDynamicmethod fromScrollEventto the baseEventPayloadinterface, defaulting the implemention to returning a null value.Changelog
[Internal]
Differential Revision: D71046682