-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Move duplicated code portion to a static method in the APIKeyBase
super class
#3142
♻️ Move duplicated code portion to a static method in the APIKeyBase
super class
#3142
Conversation
📝 Docs preview for commit 4a80d02 at: https://608d27c61facd91cca0729bf--fastapi.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #3142 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 243 531 +288
Lines 7419 13623 +6204
===========================================
+ Hits 7419 13623 +6204
Continue to review full report at Codecov.
|
📝 Docs preview for commit 8ce0578 at: https://627e2fec25b877508f6395dc--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@patrick91 : could you have another look at this PR, as it's not succeeding the linting step? 🙏 [Update]: I've gone in and fixed it 😉 |
APIKeyBase
super class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you! 🚀
And thanks for the reviews and help! ☕
The code block below was used 3 times:
I have moved this portion to the
staticmethod
into the super class as it will be shared by inheritance to all 3 subclasses.