-
Notifications
You must be signed in to change notification settings - Fork 11
Add fiboa improve command #79 #21 #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2024
This was
linked to
issues
Nov 13, 2024
ivorbosloper
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Todo: Depending on #119, make changes here and in converters accordingly. Maybe also add an option for explode_multipolygons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #21, #79 and #113
Needed to do various of these operations anyway for the fiboaGPT demo, so went ahead and directly wrote it as code. No tests yet.
Various "improvements" can be applied to a fiboa GeoParquet file.
The commands allows to
--crs
)-gp1
) and compression (-pc
)-sz
)-g
)-r
)Example:
fiboa improve file.parquet -o file2.parquet -g -sz -r old=new -pc zstd
Check
fiboa improve --help
for more details.This also implements a way to pass through custom schemas as we define them through MISSING_SCHEMAS in the converters. The schemas can then also be used for validation and will be passed through the merge/improve commands. This also results in less warnings writing the Parquet files etc.