add changes to match the new api spec, add imagen, and google-ai support #6907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vertex AI Mock Responses Check
|
Coverage Report 1This report is too large (233,339 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Test Results100 tests 27 ✅ 7s ⏱️ For more details on these failures, see this check. Results for commit 22fd4075. ♻️ This comment has been updated with latest results. |
|
The public api surface has changed for the subproject firebase-vertexai: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
davidmotson
commented
Apr 24, 2025
firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAIRegistrar.kt
Outdated
Show resolved
Hide resolved
davidmotson
commented
Apr 24, 2025
firebase-ai/src/main/kotlin/com/google/firebase/ai/LiveGenerativeModel.kt
Show resolved
Hide resolved
added 2 commits
April 23, 2025 19:44
rlazo
reviewed
Apr 24, 2025
firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAI.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAI.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAI.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAIMultiResourceComponent.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAIRegistrar.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/GenerativeModel.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/common/Request.kt
Outdated
Show resolved
Hide resolved
daymxn
requested changes
Apr 25, 2025
firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAI.kt
Outdated
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/common/APIController.kt
Show resolved
Hide resolved
firebase-ai/src/main/kotlin/com/google/firebase/ai/type/GenerativeBackend.kt
Show resolved
Hide resolved
firebase-ai/src/test/java/com/google/firebase/ai/common/util/descriptorToJson.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+238
to
+241
| /** | ||
| * A variant of [goldenUnaryFile] for developer api tests Loads the *Golden File* and automatically | ||
| * provides it to the channel. | ||
| * |
There was a problem hiding this comment.
Suggested change
| /** | |
| * A variant of [goldenUnaryFile] for developer api tests Loads the *Golden File* and automatically | |
| * provides it to the channel. | |
| * | |
| /** | |
| * A variant of [goldenUnaryFile] for developer api tests. | |
| * | |
| * Loads the *Golden File* and automatically provides it to the channel. | |
| * |
There was a problem hiding this comment.
I'm not sure I understand the diff here.
rlazo
reviewed
Apr 25, 2025
firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAI.kt
Outdated
Show resolved
Hide resolved
rlazo
reviewed
Apr 25, 2025
firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAI.kt
Outdated
Show resolved
Hide resolved
rlazo
approved these changes
Apr 25, 2025
davidmotson
merged commit 40a16cc
into
davidmotson.firebase-ai
249 of 257 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.