Skip to content

Exclude protolite well known types from version bump. #6909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Apr 24, 2025

Per b/413403910,

This adds filtering logic to not bump the version of protolite-well-known-types when it releases. This solves the issue of the version and latestReleasedVersion not aligning (which must be enforced due to b/285892320).

More specifically, this PR adds a toggle for the default bump behavior in VersionBumpTask. We then set this to false when the project's artifactId is protolite-well-known-types.

This allows us to still [automatically] update the latestReleasedVersion (should we ever release well known types again), without bumping the version.

The VersionBumpTask docs have been updated to accommodate this.

Copy link
Contributor

github-actions bot commented Apr 24, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@daymxn daymxn enabled auto-merge (squash) April 24, 2025 18:45
Copy link
Contributor

github-actions bot commented Apr 24, 2025

Test Results

 1 016 files  + 1 016   1 016 suites  +1 016   34m 28s ⏱️ + 34m 28s
 5 788 tests + 5 788   5 765 ✅ + 5 765  22 💤 +22  1 ❌ +1 
11 639 runs  +11 639  11 594 ✅ +11 594  44 💤 +44  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 3441850. ± Comparison against base commit 4fb4dfd.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2025

Coverage Report 1

This report is too large (68,765 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/E8Qh22iXwc.html

@daymxn daymxn merged commit b4a2197 into main Apr 28, 2025
259 of 263 checks passed
@daymxn daymxn deleted the daymon-exclude-pwkt-from-version-bump branch April 28, 2025 18:30
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,599 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mYmE9R04iZ/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants