Disable new SWIG string helper functions #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SWIG 4.3 added a class SWIGStringWithLengthHelper, https://github.com/swig/swig/blob/d9edb22d1c896186b41505376c77a2d296447396/Lib/csharp/csharphead.swg#L329, which is causing some users to have build errors, because it isn't defining the native symbols correctly. Disable it via the provided compile flag, which should prevent it from adding the C# symbols, and the dependency on the missing C++ symbols.
Bug: #1139
Testing
Verifying that the generated output is missing the C# symbols
https://github.com/firebase/firebase-unity-sdk/actions/runs/11826822953
Type of Change
Place an
xthe applicable box: