out_s3: miscellaneous fixes #2638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
PettitWesley
requested review from
edsiper,
fujimotos and
koleini
as code owners
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
fujimotos
approved these changes
Oct 5, 2020
|
Thanks Please adjust commit message for 401bd2d |
|
@eduardo FWIW, With this patch and the following patches applied, |
edsiper
reviewed
Oct 5, 2020
| @@ -212,7 +214,7 @@ int s3_store_init(struct flb_s3 *ctx) | |||
| struct flb_fstore_stream *fs_stream; | |||
|
|
|||
| /* Initialize the storage context */ | |||
| fs = flb_fstore_create(ctx->store_dir); | |||
There was a problem hiding this comment.
hmm buffer dir is there to include the bucket name in the filesystem path, but we are not longer using it. Is this 100% functional ?, I am not confident backlog chunks will be loaded if there is a different directory structure
|
thanks @PettitWesley and @fujimotos I did a manual pick of the commits on this PR note: PR MANUALLY MERGED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Documentation
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.