Skip to content

Added support for deploying multiple fluentbit collector replicas #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

solidDoWant
Copy link
Contributor

What this PR does / why we need it:

Fluent bit collectors can only be deployed with one replica. Deploying multiple requires deploying separate collector resources and handling iterative naming (e.g. collector-1, collector-2) manually. This PR adds the replica field, matching the fluentd collector logic.

Which issue(s) this PR fixes:

N/A

Does this PR introduced a user-facing change?

Added the ability to deploy multiple fluentbit collector replicas.

Additional documentation, usage docs, etc.:

N/A

Signed-off-by: Fred Heinecke <fred.heinecke@yahoo.com>
@solidDoWant solidDoWant force-pushed the feat/add-fluentbit-collector-replica-support-1 branch from 71ce68d to 601ff3d Compare April 17, 2025 06:03
@wenchajun
Copy link
Member

I think this is a good modification, but here replicas should be given a default value in the helm package and yaml file.

Signed-off-by: Fred Heinecke <fred.heinecke@yahoo.com>
@solidDoWant
Copy link
Contributor Author

solidDoWant commented May 6, 2025

@wenchajun is this sufficient? This now matches the same logic that is used for Fluentd STSs. There are not currently any kind: Collector manifests in the repo.

@wenchajun
Copy link
Member

@wenchajun is this sufficient? This now matches the same logic that is used for Fluentd STSs. There are not currently any kind: Collector manifests in the repo.

config like this https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/values.yaml#L450. You can also write it down and comment it out. But I think it has to be reflected in chat&&yaml.

@wenchajun
Copy link
Member

@wenchajun is this sufficient? This now matches the same logic that is used for Fluentd STSs. There are not currently any kind: Collector manifests in the repo.

That is fine,too

@wenchajun wenchajun merged commit d837356 into fluent:master May 6, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants