Skip to content

helm: Use the default transport pool to preserve proxy settings #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

souleb
Copy link
Member

@souleb souleb commented May 17, 2024

fixes #1485

@Valgueiro
Copy link

FYI: I tested in my issue environment and it worked! Thanks for that @souleb

@stefanprodan stefanprodan changed the title Use the transport pool helm: Use the default transport pool to preserve proxy settings Jun 14, 2024
@stefanprodan stefanprodan added area/helm Helm related issues and pull requests backport:release/v1.3.x To be backported to release/v1.3.x labels Jun 14, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb 🏅

If implemented, A transport from the pool with safe defaults will be used when creating an oci registry client.
This will enable using the proxy configuration.

Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb merged commit 09575db into main Jun 14, 2024
10 checks passed
@souleb souleb deleted the fix-1485 branch June 14, 2024 07:01
@fluxcdbot
Copy link
Member

Successfully created backport PR for release/v1.3.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests backport:release/v1.3.x To be backported to release/v1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiving chart pull error on environment with a proxy - EOF
4 participants