Add support for .spec.proxySecretRef for gcp provider of Bucket API #1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuscscp
force-pushed
the
bucket-gcp-proxy
branch
from
c88ba0e to
a2d79c0
Compare
matheuscscp
changed the title
matheuscscp
force-pushed
the
bucket-gcp-proxy
branch
from
a2d79c0 to
d06aaec
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
matheuscscp
force-pushed
the
bucket-gcp-proxy
branch
2 times, most recently
from
756afe8 to
4af4af7
Compare
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
bucket-gcp-proxy
branch
from
4af4af7 to
551ba1d
Compare
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
bucket-gcp-proxy
branch
from
551ba1d to
3b2c2eb
Compare
|
This doesn't work with JSON Service Account Keys, neither with OIDC auth. I was able to use a proxy for a public bucket, but nothing works if the bucket requires authn/authz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1493
Builds on #1500