Patch status sub-resource #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
patch-status
branch
from
3ab9307 to
be81846
Compare
starlingx-github
pushed a commit
to starlingx/ansible-playbooks
that referenced
this pull request
Dec 7, 2022
There are several FluxCD issues which were attempted to be fixed by
implementing recovery logic into app framework. A new issue was
observed that may be hit more often because of the recovery logic.
Flux won't attempt to finish updating a HelmRelease resource to
Ready=True but only display a message containing this signature:
'''the object has been modified...'''. The resource must be correctly
updated by Flux.
Aside from this the recovery logic was put in place for HelmChart
resources that are in Ready=False state, but this should have been
handled by Flux.
I believe the 2 issues described above map to [1] and [2].
To pull [1] and [2] updated FluxCD release to latest available [3].
Release is composed of manifests and container image used.
Update containers used: helm-controller from v0.15.0 to v0.27.0,
source-controller from v0.20.1 to v0.32.1.
Update flux crds, rbac, deployment.
Changelog claims we get k8s 1.25 support part of the upversion.
Disclaimer for tests:
1) Recovery logic concerned with flipping spec.suspend was removed.
Introduced by ongoing [4]
2) optimization by flipping spec.suspend was removed
Introduced by ongoing[4]
3) cert-manager, nginx-ingress-controller, platform-integ-apps had the
reconciliation interval decreased to 1m to allow Flux to manage the
resources by itself in a reasonable time interval.
There will be future commits per app updating reconciliation interval.
Tests on AIO-SX:
PASS: bootstrap
PASS: unlocked enabled available
PASS: apps applied
PASS: tested on k8s 1.24.4 and 1.21.8, inherit that versions between
should be OK
PASS: delete pods and see they are recreated and no errors
PASS: inspect flux pod logs for errors
PASS: re-test known trigger for 1996747 and 1995748
[1]: fluxcd/source-controller#703
[2]: fluxcd/source-controller#202
[3]: https://github.com/fluxcd/flux2/releases/tag/v0.37.0
[4]: https://review.opendev.org/c/starlingx/config/+/866862
Related-Bug: 1995748
Related-Bug: 1996747
Closes-Bug: 1999032
Signed-off-by: Dan Voiculeasa <dan.voiculeasa@windriver.com>
Change-Id: Id295599a2946f48081e7d27e2ab8e06063c3c88d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces status updates with patches to avoid "the object has been modified; please apply your changes to the latest version and try again".