-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Enable forge create without signed tx #1060
Comments
I do not understand what you are saying? There is no 'synchronize' |
Please keep it civil 😄 |
truffle / hardhat both have this capability |
I'm trying to infer here, so correct me if I'm wrong. Going by #1273 (comment) and some of the details in this issue If I understand correctly, you want to sign with a remote signer. This should already be possible using So:
Lastly, "At minimum forge should wait for a transaction receipt." - it already does this, so if you are observing something different, please provide steps to reproduce. I've had some troubles understanding exactly what this issue was about since it talks about wallet providers, receipts and MetaMask RPC support (which I don't think is a thing?), but the title of the issue suggest you want a |
Not the author but I was looking for a |
Thank you for the detailed response. I will try later today. Also for metamask support I am using this: https://github.com/manifoldfinance/walletbus which basically bridges the shell to the browser window where metamask is enabled. |
@chimera-defi given an ABI file you can call encode a transaction using this utility: https://www.npmjs.com/package/solidity-gencall - is this something like you are looking for? I am pretty sure there is a way to do the same in Foundry through cast as well |
Hey @sambacha something like that yea but would be nice to have in rust as part of foundry instead of as a standalone npm repo. |
If you want to deploy from a Hardware wallet, you can use |
Thank you. Appreciate it.
Missed it on my first skim through the docs I guess.
…On Mon, Apr 18, 2022 at 8:37 AM, Bjerg ***@***.***> wrote:
If you want to deploy from a Hardware wallet, you can use --ledger or --trezor. See the [docs](https://book.getfoundry.sh/reference/forge/forge-create.html) (specifically the wallet options)
—
Reply to this email directly, [view it on GitHub](#1060 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ATQNYJYMOUHTLEZZN7ITI6LVFVJPJANCNFSM5RWDWZDA).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
The problem is
Also, setting ETH_FROM gives me this error:
BUT cast send --rpc-url http://localhost:24012/rpc --from 0xcFa7Eae32032bF431aEd95532142A9c2B35715D4 0xcFa7Eae32032bF431aEd95532142A9c2B35715D4 works? |
I end up getting this error now: $ cast send --rpc-url http://localhost:24012/rpc --from 0xcFa7Eae32032bF431aEd95532142A9c2B35715D4 0xcFa7Eae32032bF431aEd95532142A9c2B35715D4 --gas-price 15010499
Error:
0: (code: -32602, message: Invalid transaction envelope type: specified type "0x02" but including maxFeePerGas and maxPriorityFeePerGas requires type: "0x2", data: None) |
This seems like a totally separate issue? Can you please clarify what this issue is about? |
This is working now for forge as well, thx! |
Component
Forge, Cast
Describe the feature you would like
I would like to use metamask or hashicorp vault to sign transactions for deployments. Forge currently requires a key be provided, it does not wait/poll for the request to return/etc. At minimum forge should wait for a transaction receipt. This is how metamask support would work: it sends the transaction signing request via rpc to metamask, metamask will return a transaction hash to it.
Additional context
No response
The text was updated successfully, but these errors were encountered: