Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forge): use float total cmp instead partial #10005

Merged
merged 1 commit into from
Mar 4, 2025
Merged

fix(forge): use float total cmp instead partial #10005

merged 1 commit into from
Mar 4, 2025

Conversation

grandizzy
Copy link
Collaborator

Motivation

Solution

  • use float total_cmp instead of partial_cmp to get a total order

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Mar 4, 2025
@grandizzy grandizzy changed the title fix(forge): use total cmp instead partial fix(forge): use float total cmp instead partial Mar 4, 2025
@grandizzy grandizzy marked this pull request as ready for review March 4, 2025 10:37
zerosnacks
zerosnacks approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, makes sense 👍

@grandizzy grandizzy merged commit d3704ee into foundry-rs:master Mar 4, 2025
22 checks passed
@grandizzy grandizzy deleted the issue-10001 branch March 4, 2025 15:57
Dargon789 added a commit to Dargon789/foundry that referenced this pull request Mar 4, 2025
@Dargon789 @grandizzy
fix(forge): use float total cmp instead partial (foundry-rs#10005) (#17)
1e98af9 
fix(forge): use total cmp instead partial

Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com>
Dargon789 added a commit to Dargon789/foundry that referenced this pull request Mar 4, 2025
@Dargon789
Revert "fix(forge): use float total cmp instead partial (foundry-rs#1…
f2f7b8c 
…0005) (#17)"

This reverts commit 1e98af9.
Dargon789 added a commit to Dargon789/foundry that referenced this pull request Mar 4, 2025
@Dargon789
Revert "fix(forge): use float total cmp instead partial (foundry-rs#1…
02e28ab 
…0005) (#17)" (#18)

This reverts commit 1e98af9.
@grandizzy grandizzy self-assigned this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees

@grandizzy grandizzy

Labels
C-forge Command: forge T-bug Type: bug
Projects
Foundry
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: forge snapshot --diff panic when using named return variable
2 participants
@grandizzy @zerosnacks