Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forge): avoid etch panic on invalid bytecode #10006

Merged
merged 1 commit into from
Mar 4, 2025
Merged

fix(forge): avoid etch panic on invalid bytecode #10006

merged 1 commit into from
Mar 4, 2025

Conversation

grandizzy
Copy link
Collaborator

Motivation

Solution

  • use new_raw_checked instead new_raw when creating bytecode and present err to user
    image

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy mentioned this pull request Mar 4, 2025
Closed
2 tasks
@grandizzy grandizzy marked this pull request as ready for review March 4, 2025 11:19
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Mar 4, 2025
zerosnacks
zerosnacks approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, makes sense how fuzzing a vm.etch target could result in this

@grandizzy grandizzy merged commit 09b0a0c into foundry-rs:master Mar 4, 2025
22 checks passed
@grandizzy grandizzy deleted the issue-9983 branch March 4, 2025 11:42
@Yasersarhadikarbasak
Copy link

بسیار عالی

@Yasersarhadikarbasak
Copy link

کامل ترین

@Yasersarhadikarbasak
Copy link

پشتیبانی کن

@grandizzy grandizzy self-assigned this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees

@grandizzy grandizzy

Labels
C-forge Command: forge T-bug Type: bug
Projects
Foundry
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(forge test): running test result in Expect correct EOF bytecode: Eip7702(InvalidLength)
3 participants
@grandizzy @Yasersarhadikarbasak @zerosnacks