Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forge): stack pranks, restore pranks at earlier call depths #10018

Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix(forge): stack pranks, restore pranks at earlier call depths #10018

merged 1 commit into from
Mar 7, 2025

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Mar 6, 2025 •
edited by zerosnacks
Loading

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge T-likely-breaking Type: requires changes that can be breaking labels Mar 6, 2025
@grandizzy grandizzy marked this pull request as ready for review March 6, 2025 08:14
zerosnacks
zerosnacks approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! pending review cc @yash-atreya

mattsse
mattsse approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 23191fb into foundry-rs:master Mar 7, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-bug Type: bug T-likely-breaking Type: requires changes that can be breaking
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(forge): msg.sender set using startPrank in another contract is wrong
3 participants
@grandizzy @mattsse @zerosnacks