test(utils): add test for erc7201 utility function #10394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarkk01
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
grandizzy
requested changes
Apr 28, 2025
zarkk01
force-pushed
the
test/erc7201-utils
branch
from
2b061dd to
1b5fcbb
Compare
hey @grandizzy , is it good now? sorry, its my first PR :) |
|
This is already tested in the documentation (doctest), these don't add anything of value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
erc7201formula currently lacks dedicated tests. Introducing these tests ensures the reliability of its implementation.Solution
Added unit tests for the
erc7201formula inutils.rs, covering , among others, a standard case ofexample.mainto validate its behavior.PR Checklist