feat(cast): Add file option for calldata input #10397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayushdubey86
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
Closed
2 tasks
grandizzy
requested changes
Apr 28, 2025
Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com>
|
Have pushed test case @grandizzy , please do check them out once free! |
DaniPopes
reviewed
Apr 29, 2025
crates/cast/src/args.rs
Outdated
| let final_args = if let Some(file_path) = file { | ||
| let contents = fs::read_to_string(file_path)?; | ||
| let contents = contents.trim(); | ||
| vec![contents.to_string()] |
There was a problem hiding this comment.
This is not correct as it treats the entire file as a single argument. It should split the string into arguments using .lines().collect(). This should also be done above in AbiEncode since it's a similar command
|
Have made those changes , do check them out @DaniPopes |
mattsse
approved these changes
May 1, 2025
Comment on lines
+200
to
+209
| let contents = fs::read_to_string(file_path)?; | ||
| contents | ||
| .lines() | ||
| .map(str::trim) | ||
| .filter(|line| !line.is_empty()) | ||
| .map(String::from) | ||
| .collect() | ||
| } else { | ||
| args | ||
| }; |
There was a problem hiding this comment.
this looks alright to me,
having 1 line per arg seems okay
grandizzy
changed the title
|
This should also be added to abi encode above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue should close #10013 .
Hello @yash-atreya @zerosnacks @grandizzy please review it once free!