Fix shadowed branch coverage PC variable #8040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DaniPopes Should we add tests for this? I didn't find any tests related to anchors. |
DaniPopes
approved these changes
Jun 3, 2024
|
Don't know much about this code so can't say lol, thanks for catching this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor of coverage code (#8025) is casting a shadow over
pcvariable for the first branch and results in invalid branch coverage reports.Motivation
Fix branch coverage reports.
Solution
Use a different name for the jump
pcvariable to prevent shadowing it for use in the first branch anchor.