feat(traces): use TraceWriter, delegating the formatting of the print trace to revm-inspectors
#8224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
commented
Jun 21, 2024
zerosnacks
commented
Jun 21, 2024
DaniPopes
reviewed
Jun 24, 2024
mattsse
reviewed
Jun 27, 2024
mattsse
pushed a commit
to paradigmxyz/revm-inspectors
that referenced
this pull request
Jun 27, 2024
Closes: #14 - Add `nodes_mut` for mutability of nodes, required for populating added CallTrace fields - Adds `decoded.label`, `decoded.return_data`, `decoded.call_data`, wrapped in the `DecodedCallTrace` container type. - Wraps the raw `LogData` in a `CallLog` to accompany it with additional decoded data fields: `decoded.name`, `decoded.params`, wrapped in the `DecodedCallLog` container type. `decoded.contract_name` has not been added as a field as it is only used in Foundry's gas report, not in the current trace render. It is likely that some stylistic updates will be followed up relatively quickly Related PR: foundry-rs/foundry#8224 --------- Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
…w as it is not supported by revm-inspector, uses &mut and only pass into the trace extender what is necessary
zerosnacks
commented
Jun 28, 2024
|
Marking as ready for review, pending |
DaniPopes
reviewed
Jun 28, 2024
DaniPopes
reviewed
Jun 28, 2024
DaniPopes
reviewed
Jul 1, 2024
DaniPopes
requested changes
Jul 2, 2024
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
…:foundry-rs/foundry into zerosnacks/trace-printer-revm-inspectors
DaniPopes
requested changes
Jul 4, 2024
DaniPopes
approved these changes
Jul 4, 2024
mattsse
approved these changes
Jul 5, 2024
agostbiro
added a commit
to NomicFoundation/edr
that referenced
this pull request
Oct 28, 2024
Based on foundry-rs/foundry#8224 Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
agostbiro
added a commit
to NomicFoundation/edr
that referenced
this pull request
Oct 29, 2024
Based on foundry-rs/foundry#8224 Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes paradigmxyz/revm-inspectors#14
Related PR: paradigmxyz/revm-inspectors#151
Solution
CallTracedecoder.decode(nowextend_trace)revm-inspectors