-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(anvil): use Alloy otterscan types #8318
Conversation
Please format using nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unable to review this with all the ;
changes ;)
First commit contains all the relevant changes. In the second commit I synced the fork and this caused the fmt check to fail. Shall I revert the last commit? |
This reverts commit bf1969f.
@mattsse Hopefully better, sorry! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm last nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending @mattsse
@mattsse gm |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gm!
Motivation
Closes #8298
Solution
Deprecates
anvil/src/eth/otterscan/types.rs
in favor of Alloy's otterscan types. As recommended by @DaniPopes, logic is moved intootterscan/api.rs
expandingBackend
implementations and adding free functions.