Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anvil): use Alloy otterscan types #8318

Merged
merged 12 commits into from
Jul 5, 2024

Conversation

fedemagnani
Copy link
Contributor

@fedemagnani fedemagnani commented Jul 1, 2024

Motivation

Closes #8298

Solution

Deprecates anvil/src/eth/otterscan/types.rs in favor of Alloy's otterscan types. As recommended by @DaniPopes, logic is moved into otterscan/api.rs expanding Backend implementations and adding free functions.

@DaniPopes
Copy link
Member

Please format using nightly cargo +nightly fmt

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unable to review this with all the ; changes ;)

@fedemagnani
Copy link
Contributor Author

fedemagnani commented Jul 1, 2024

unable to review this with all the ; changes ;)

First commit contains all the relevant changes.

In the second commit I synced the fork and this caused the fmt check to fail.
So I pushed the third commit (containing all the ; fixes) after running cargo fmt which edited modules not involved in my PR.

Shall I revert the last commit?

drun added 2 commits July 1, 2024 14:50
This reverts commit bf1969f.
@fedemagnani
Copy link
Contributor Author

@mattsse Hopefully better, sorry! :)

@fedemagnani fedemagnani requested a review from mattsse July 1, 2024 14:18
@DaniPopes DaniPopes changed the title Alloy otterscan types (Issue 8298) feat(anvil): use Alloy otterscan types Jul 2, 2024
@fedemagnani fedemagnani requested a review from DaniPopes July 2, 2024 19:57
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm last nit

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending @mattsse

@DaniPopes
Copy link
Member

@mattsse gm

@fedemagnani

This comment was marked as resolved.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gm!

@mattsse mattsse enabled auto-merge (squash) July 5, 2024 05:57
@mattsse mattsse merged commit 642f13f into foundry-rs:master Jul 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace otterscan types with alloy's otterscan types
3 participants