Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: threads and show_progress per profile config #8341

Merged
merged 7 commits into from
Jul 4, 2024
Merged

chore: threads and show_progress per profile config #8341

merged 7 commits into from
Jul 4, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Jul 3, 2024 •
edited
Loading

Motivation

  • rn there's no way to set show test progress and max test threads per profile but they can only be passed as args

Solution

  • rename max_threads to threads with jobs / j alias
  • allow per profile config and as env var for threads and show_progress
  • pending PR to update docs once this is merged

@grandizzy grandizzy changed the title chore: allow max threads and show progress set per profile chore: max_threads and show_progress per profile config Jul 3, 2024
@grandizzy grandizzy marked this pull request as ready for review July 3, 2024 13:42
DaniPopes
DaniPopes reviewed Jul 3, 2024
View reviewed changes
@grandizzy grandizzy changed the title chore: max_threads and show_progress per profile config chore: threads and show_progress per profile config Jul 3, 2024
mattsse
mattsse approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

pending @DaniPopes

DaniPopes
DaniPopes requested changes Jul 4, 2024
View reviewed changes
grandizzy and others added 2 commits July 4, 2024 19:35
@grandizzy @DaniPopes
Update crates/config/README.md
f950b01 
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
@grandizzy
Use usize for number of threads
65d3e61
@DaniPopes DaniPopes enabled auto-merge (squash) July 4, 2024 17:01
@DaniPopes DaniPopes merged commit 042b490 into foundry-rs:master Jul 4, 2024
20 checks passed
@grandizzy grandizzy mentioned this pull request Jul 5, 2024
Merged
@grandizzy grandizzy deleted the profile-configs branch July 5, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grandizzy @mattsse @DaniPopes