-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(anvil): add callTracer support for debug_traceCall #8375
Merged
mattsse
merged 12 commits into
foundry-rs:master
from
jakim929:debug-tracecall-calltracer
Jul 10, 2024
Merged
feat(anvil): add callTracer support for debug_traceCall #8375
mattsse
merged 12 commits into
foundry-rs:master
from
jakim929:debug-tracecall-calltracer
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
this looks correct
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#5855
currently only
debug_traceTransaction
supports builtin tracer typecallTracer
. AddingcallTracer
support fordebug_traceCall
will be useful when analyzing transaction requests that have not been mined yet.Solution
Followed the high level approach in the reth implementation https://github.com/paradigmxyz/reth/blob/454416809854b9ee9a5c64c90b0b48f39eb8891a/crates/rpc/rpc/src/debug.rs#L275
Added all matchers since we'll have to add all the tracers at some point
Instead of defaulting to the default structlog tracer if tracerType isn't supported, the API explicitly returns an InvalidParams error (to prevent issues like Anvil's gas response for trace_debugTransaction is inconsistent with geth's responses for tracer 'callTracer' #6873 where it looks like an implementation bug when the feature just isn't supported yet)
Added integration tests for debug_traceCall callTracer that tests internal calls using SimpleStorage and Multicall
Out of scope
callTracer
(in a separate PR)