Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cast): correctly handle legacy chains #8420

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix(cast): correctly handle legacy chains #8420

merged 1 commit into from
Jul 11, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Jul 11, 2024

Motivation

Closes #8418

we didn't respect chain.is_legacy() when setting maxFeePerGas

Solution

@klkvr klkvr mentioned this pull request Jul 11, 2024
Closed
2 tasks
mattsse
mattsse approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@klkvr klkvr enabled auto-merge (squash) July 11, 2024 17:17
@klkvr klkvr merged commit 1bfbaff into master Jul 11, 2024
20 checks passed
@klkvr klkvr deleted the klkvr/fix-legacy branch July 11, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: both gasPrice and (maxFeePerGas or maxPriorityFeePerGas) specified
3 participants
@klkvr @mattsse @DaniPopes