Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(foundryup): check for running processes #9680

Merged
merged 1 commit into from
Jan 14, 2025
Merged

feat(foundryup): check for running processes #9680

merged 1 commit into from
Jan 14, 2025

Conversation

grandizzy
Copy link
Collaborator

Motivation

supersede #7970

  • Reuse proposed check_bins_in_use and call it when --install and --use
  • add fallback to warning message if pgrep not installed

Solution

@grandizzy grandizzy marked this pull request as ready for review January 14, 2025 09:46
zerosnacks
zerosnacks approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, works well

Tested on Linux and MacOS

@grandizzy grandizzy merged commit ff2c564 into foundry-rs:master Jan 14, 2025
22 checks passed
@grandizzy grandizzy deleted the foundryup-check branch January 14, 2025 10:41
@grandizzy grandizzy mentioned this pull request Jan 14, 2025
Closed
@grandizzy grandizzy self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees

@grandizzy grandizzy

Labels
None yet
Projects
Foundry
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grandizzy @zerosnacks