Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve windows path related tests #434

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

Miauwkeru
Copy link
Contributor

  • Tests regarding NamedTemparyFile (because it cannot be opened twice)
  • Tests regarding path normalization
  • Tests regarding vfs.map_dir

(DIS-2426)

@Miauwkeru Miauwkeru requested a review from Poeloe November 3, 2023 14:58
@Miauwkeru Miauwkeru force-pushed the fix-windows-config-filsystem-tests branch from 244a5c1 to ff2ed79 Compare November 3, 2023 15:21
Poeloe
Poeloe previously approved these changes Nov 3, 2023
Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

- Tests regarding NamedTemparyFile (because it cannot be opened twice)
- Tests regarding path normalization
- Tests regarding vfs.map_dir

(DIS-2426)
@Miauwkeru Miauwkeru force-pushed the fix-windows-config-filsystem-tests branch from cd36206 to 5ad0f31 Compare November 6, 2023 09:33
@Miauwkeru Miauwkeru merged commit ba5fed3 into main Nov 6, 2023
@Miauwkeru Miauwkeru deleted the fix-windows-config-filsystem-tests branch November 6, 2023 09:45
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
- Tests regarding NamedTemparyFile (because it cannot be opened twice)
- Tests regarding path normalization
- Tests regarding vfs.map_dir

Note: Not all path related tests

(DIS-2426)
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
- Tests regarding NamedTemparyFile (because it cannot be opened twice)
- Tests regarding path normalization
- Tests regarding vfs.map_dir

Note: Not all path related tests

(DIS-2426)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants