add tests for symlink logic MappedFile #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecinestpasunepipe
force-pushed
the
DIS-1796_MappedFile_Symlink
branch
4 times, most recently
from
4658827 to
c33d16e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
=======================================
Coverage 73.96% 73.96%
=======================================
Files 284 284
Lines 23540 23540
=======================================
+ Hits 17411 17412 +1
+ Misses 6129 6128 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Current behaviour is ok. Attempt to change it breaks. Added unittests to confirm behaviour and protect against regressions. |
Poeloe
approved these changes
Feb 23, 2024
cecinestpasunepipe
changed the title
cecinestpasunepipe
force-pushed
the
DIS-1796_MappedFile_Symlink
branch
from
c33d16e to
b2775cf
Compare
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DIS-1796)