Fix NEON bug in convert_vec3_to_vec4W0
and reenable tests
#1354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #1353 on my Mac I incidentally got
gtc_type_aligned.cpp
to run 😅First issue is a compile error in
convert_splat
:Switching to a plain
0
constant seems to make things happy on my machine, though if that causes problems elsewhere we could use{}
T()
instead.Next was a test failure in
test_copy_vec4_vec3
wherexyz0(vec3(1, 2, 3))
was returning(0, 2, 3, 4)
instead of(1, 2, 3, 0)
! This turned out to be a simple flipped mask order infunc_common_simd.inl
.With these changes the tests now run and pass on my M1 Mac, and hopefully also CI.