Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NEON bug in convert_vec3_to_vec4W0 and reenable tests #1354

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alusch
Copy link

@alusch alusch commented Mar 21, 2025

While testing #1353 on my Mac I incidentally got gtc_type_aligned.cpp to run 😅

First issue is a compile error in convert_splat:

error: implicit conversion increases floating-point precision: 'float' to 'double'

Switching to a plain 0 constant seems to make things happy on my machine, though if that causes problems elsewhere we could use {} T() instead.

Next was a test failure in test_copy_vec4_vec3 where xyz0(vec3(1, 2, 3)) was returning (0, 2, 3, 4) instead of (1, 2, 3, 0)! This turned out to be a simple flipped mask order in func_common_simd.inl.

With these changes the tests now run and pass on my M1 Mac, and hopefully also CI.

@ZXShady
Copy link

ZXShady commented Mar 22, 2025

Be aware that {} casting is only usable in C++11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants