Fix validation of model parameters using schemas.

[GernotMaier]

The validation of model parameters using schema generates several errors (see #1301).

This PR fixes those:

• correct handling of "value": null cases (values are None)
• correct handling of booleans (values where wrongly converted to int along the way in the code)
• incomplete effective focal length schema description (added 4 additional columns)
• fix getting of column type description for cases where the schema file has one single entry to describe several entries of identical type (as e.g., in nsb_pixel_rate)

Closes #1301

[Copilot]

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/simtools/data_model/validate_data.py:199

• Returning [None] in case of TypeError might mask other issues. Consider handling the error more specifically.

return [None], target_unit

[ctao-dpps-sonarqube]

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 83.30% Coverage (93.20% Estimated after merge)
• 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[tobiaskleiner]

should here and in the following be a allowed range?

[GernotMaier]

I think the displacement does not have a limit (there is obviously a limit given by the size of the telescopes).

[tobiaskleiner]

Ok all good then, thanks!

[GernotMaier]

Thanks @tobiaskleiner !