Skip to content

Remove sandboxes #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Conversation

GernotMaier
Copy link
Contributor

@GernotMaier GernotMaier commented Jan 30, 2025

Note: merges into db-simulation-model-refactoring branch - the 3 integration tests fails until PR #1319 is reviewed an merged

I have carefully looked through the tests for db_handler and we don't use any sandboxes anymore. I therefore remove all related code.

@GernotMaier GernotMaier self-assigned this Jan 30, 2025

This comment has been minimized.

@GernotMaier GernotMaier marked this pull request as ready for review January 30, 2025 08:53
Copy link
Collaborator

@tobiaskleiner tobiaskleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GernotMaier, thanks and all looks good.

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (93.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

@GernotMaier GernotMaier merged commit 907093d into db-simulation-model-refactoring Jan 30, 2025
12 checks passed
@GernotMaier GernotMaier deleted the grow-out-of-sandboxes branch January 30, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants